Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use escaped diacrytics #916

Closed
wants to merge 1 commit into from
Closed

Use escaped diacrytics #916

wants to merge 1 commit into from

Conversation

cibernox
Copy link
Owner

Closes #915

@kumkanillam can you pull this branch and confirm that it works for you?

@kumkanillam
Copy link

Still getting the same error. please click on the below link for verification
balel.js try it online where I pasted your escaped version of this, but babili minification still minifying without quotes for identifier...When I paste it in IE-11 browser console, I get Invalid character error.

@cibernox
Copy link
Owner Author

@kumkanillam I see. Not sure what to do on my side to make this work. I think that you have to report the error in babili itself, or one of it's plugins.

@kumkanillam
Copy link

@cibernox Thank you quick the response. After the minification escaped versions is replaced by the non-utf8 chars. so issue still exists.. IE browser shows error link(https://docs.microsoft.com/en-us/scripting/javascript/misc/invalid-character-javascript) which has invalid character rule, but I am not sure which char is causing this error

@cibernox
Copy link
Owner Author

My point is that if the code before minification works, and after minification it doesn't, it's a bug in babili itself. My best advice is report the bug in babili. I suspect that the transform that breaks the code is actually this one: https://github.com/babel/babili/tree/master/packages/babel-plugin-transform-member-expression-literals

@cibernox
Copy link
Owner Author

cibernox commented Jun 4, 2017

Closed as this is a bug in babili, not in EPS.

@cibernox cibernox closed this Jun 4, 2017
@kumkanillam
Copy link

Here is ongoing PR for this issue. babel/minify#543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants