Wait for deletion of agent DaemonSet before deleting other resources. #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Feb 16, 2023
squeed
approved these changes
Feb 16, 2023
marseel
force-pushed
the
fix_waiting_order
branch
from
02dd601
to
f9e41e1
Compare
|
PTAL, I've also added some logging when error happens or when we successfully delete daemonset. |
Related PR: cilium/cilium#23772 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
fix_waiting_order
branch
from
f9e41e1
to
96ce44d
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the deletion of agent DaemonSet before deleting other resources.
This allows the agent to clean up cilium annotations added to the node.
Related PR: cilium/cilium#23772