hubble: Patch Cilium DaemonSet with hubble-metrics port #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far when enabling Hubble metrics in `hubble enable` command, e.g.:
```
cilium hubble enable --helm-set-string=hubble.metrics.enabled="{http,dns,drop,tcp,flow,icmp,port-distribution}"
```
the CLI created a hubble-metrics service, but didn't add a hubble-metrics port
to Cilium daemonset. Then Hubble metrics were exposed by Cilium, but the
hubble-metrics Endpoints object wasn't populated with the Cilium pod IPs.
Prometheus scrape configs often rely on Endpoints objects, so this results in
Hubble metrics not being scraped.
This patch fixes that by patching the Cilium agent daemonset with a
hubble-metrics port if a metrics service is created in `hubble enable` command.
It's a rough patch and it assumes using the default Hubble metrics port (9965),
and Cilium agent name ("cilium"). A proper solution to the problems would be
using Helm as backend for all install/update commands (cilium#1396).
Fixes cilium#1422
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
chancez
reviewed
Feb 28, 2023
chancez
approved these changes
Mar 1, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far when enabling Hubble metrics in
hubble enablecommand, e.g.:the CLI created a hubble-metrics service, but didn't add a hubble-metrics port to Cilium daemonset. Then Hubble metrics were exposed by Cilium, but the hubble-metrics Endpoints object wasn't populated with the Cilium pod IPs. Prometheus scrape configs often rely on Endpoints objects, so this results in Hubble metrics not being scraped.
This patch fixes that by patching the Cilium agent daemonset with a hubble-metrics port if a metrics service is created in
hubble enablecommand.It's a rough patch and it assumes using the default Hubble metrics port (9965), and Cilium agent name ("cilium"). A proper solution to the problems would be using Helm as backend for all install/update commands (#1396).
Fixes #1422