Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: Generate resource quotas from Helm chart #1445

Merged
merged 1 commit into from
Mar 14, 2023
Merged

install: Generate resource quotas from Helm chart #1445

merged 1 commit into from
Mar 14, 2023

Conversation

michi-covalent
Copy link
Contributor

Use Helm chart to generate resource quotas to ensure that they don't diverge between Helm and cilium-cli.

@michi-covalent
install: Generate resource quotas from Helm chart
e93edcb 
Use Helm chart to generate resource quotas to ensure that they don't
diverge between Helm and cilium-cli.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci March 9, 2023 01:02 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor Author

manually tested by installing cilium in cilium namespace on GKE:

% ./cilium install -n cilium
ℹ️  Using Cilium version 1.13.0
🔮 Auto-detected cluster name: gke-cilium-dev-us-west2-a-michi-6855
🔮 Auto-detected datapath mode: gke
🔮 Auto-detected kube-proxy has been installed
✅ Detected GKE native routing CIDR: 10.36.0.0/14
ℹ️  helm template --namespace cilium cilium cilium/cilium --version 1.13.0 --set cluster.id=0,cluster.name=gke-cilium-dev-us-west2-a-michi-6855,cni.binPath=/home/kubernetes/bin,encryption.nodeEncryption=false,gke.disableDefaultSnat=true,gke.enabled=true,ipam.mode=kubernetes,ipv4NativeRoutingCIDR=10.36.0.0/14,kubeProxyReplacement=disabled,nodeinit.enabled=true,nodeinit.reconfigureK
ubelet=true,nodeinit.removeCbrBridge=true,operator.replicas=1,serviceAccounts.cilium.name=cilium,serviceAccounts.operator.name=cilium-operator
ℹ️  Storing helm values file in cilium/cilium-cli-helm-values Secret
🔑 Created CA in secret cilium-ca
🔑 Generating certificates for Hubble...
🚀 Creating resource quota cilium-resource-quota...
🚀 Creating resource quota cilium-operator-resource-quota...
...

@michi-covalent michi-covalent marked this pull request as ready for review March 9, 2023 01:53
@michi-covalent michi-covalent requested a review from a team as a code owner March 9, 2023 01:53
@tommyp1ckles
Copy link
Contributor

Can you still override these on the command line?

@michi-covalent
Copy link
Contributor Author

Can you still override these on the command line?

yeah so they are controlled by the same helm flags. so you can do something like:

 % ./cilium install --helm-set resourceQuotas.enabled=true
🔮 Auto-detected Kubernetes kind: minikube
✨ Running "minikube" validation checks
✅ Detected minikube version "1.25.2"
ℹ️  Using Cilium version 1.13.0
🔮 Auto-detected cluster name: minikube
🔮 Auto-detected datapath mode: tunnel
🔮 Auto-detected kube-proxy has been installed
ℹ️  helm template --namespace kube-system cilium cilium/cilium --version 1.13.0 --set cluster.id=0,cluster.name=minikube,encryption.nodeEncryption=false,kubeProxyReplacement=disabled,operator.replicas=1,resourceQuotas.enabled=true,serviceAccounts.cilium.name=cilium,serviceAccounts.operator.name=cilium-operator,tunnel=vxlan
ℹ️  Storing helm values file in kube-system/cilium-cli-helm-values Secret
🔑 Created CA in secret cilium-ca
🔑 Generating certificates for Hubble...
🚀 Creating resource quota cilium-resource-quota...
🚀 Creating resource quota cilium-operator-resource-quota...

@tklauser tklauser merged commit fe38969 into master Mar 14, 2023
@tklauser tklauser deleted the pr/michi/resourcequota branch March 14, 2023 07:01
@chenrui333 chenrui333 mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh was automatically assigned from cilium/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michi-covalent @tommyp1ckles @tklauser