Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: fix incorrect log error formatting directive. #1451

Merged
merged 1 commit into from
Mar 14, 2023
Merged

helm: fix incorrect log error formatting directive. #1451

merged 1 commit into from
Mar 14, 2023

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented Mar 14, 2023 •
edited

Replace logf error wrap directive with string.

Fixes ugly logs like:

⚠️ Unable to list kubernetes api resources, try --api-versions if needed: %!w(*fmt.wrapError=&{failed to list api resources: unable to retrieve the complete list of server APIs: metrics.k8s.io/v1beta1: the server is currently unable to handle the request 0x14000e26030})

@tommyp1ckles
helm: fix incorrect log error formatting directive.
c81001b 
Replace logf error wrap directive with string.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner March 14, 2023 01:27
@tommyp1ckles tommyp1ckles temporarily deployed to ci March 14, 2023 01:27 — with GitHub Actions Inactive
@michi-covalent michi-covalent merged commit 9685181 into master Mar 14, 2023
@michi-covalent michi-covalent deleted the pr/tp/fix-log-fmt-directive branch March 14, 2023 03:20
@chenrui333 chenrui333 mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh was automatically assigned from cilium/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tommyp1ckles @michi-covalent