Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tetragon Tracing Policies #1467

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

soggiest
Copy link
Contributor

This commit adds the ability to collect Tetragon tracing policies to sysdump archives.
To facilitate this change the K8s client needed to be extended to include Tetragon objects.

This commit also includes a unit test, including mock object, for this new functionality.

Also, I don't know why it says I committed something to the previous commit. I've been fighting with git rebase all afternoon to fix my commit message. Please take pity on me.

Signed-off-by: Nicholas Lane nicholas@cilium.io

@soggiest soggiest requested review from a team as code owners March 21, 2023 22:18
@soggiest soggiest temporarily deployed to ci March 21, 2023 22:18 — with GitHub Actions Inactive
@christarazi christarazi temporarily deployed to ci March 21, 2023 23:52 — with GitHub Actions Inactive
@christarazi
Copy link
Member

christarazi commented Mar 21, 2023

I've rebased it so you should be able to simply delete your local branch and re-checkout this PR (via gh pr checkout 1467) or you can just git reset --hard soggiest/pr/soggy/sysdump-improvement after git fetch --all.

Seems like you'll also need to remove the first commit by doing git rebase -i HEAD^.

@soggiest
Copy link
Contributor Author

There we go, finally successfully removed the old useless commit. Thanks for your help @christarazi!

This commit adds the ability to collect Tetragon tracing policies to sysdump archives.
To facilitate this change the K8s client needed to be extended to include Tetragon objects.

This commit also includes a unit test, including mock object, for this new functionality

Signed-off-by: Nicholas Lane <nicholas@cilium.io>
@soggiest soggiest force-pushed the pr/soggy/sysdump-improvement branch from 1d7bd3f to c1d3743 Compare March 22, 2023 04:36
@soggiest soggiest temporarily deployed to ci March 22, 2023 04:36 — with GitHub Actions Inactive
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 22, 2023
@tklauser tklauser merged commit dacac93 into cilium:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants