Sysdump: Add missing Cilium CRDs #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
approved these changes
Mar 22, 2023
Some CRDs installed by Cilium are not captured by sysdumps. This commit adds the following CRDs to sysdump archives: Cilium External Workloads (API Version: V2) Cilium Endpoint Slices (API Version: V2alpha1) This commit also includes unit tests for gathering these CRDs. Signed-off-by: Nicholas Lane <nicholas@cilium.io>
soggiest
force-pushed
the
pr/soggy/add-missing-crds
branch
from
0b1977e
to
187b37f
Compare
squeed
approved these changes
Mar 24, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CRDs installed by Cilium are not captured by sysdumps. This commit adds the following CRDs to sysdump archives:
Cilium External Workloads (API Version: V2)
Cilium Endpoint Slices (API Version: V2alpha1)
This commit also includes unit tests for gathering these CRDs.
Signed-off-by: Nicholas Lane <nicholas@cilium.io>