Add Helm-based install / uninstall commands #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
f9e3978
to
29b051a
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
29b051a
to
1c27243
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
1c27243
to
56e8ce5
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
56e8ce5
to
9a06568
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
9a06568
to
dfccfbf
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
dfccfbf
to
a7a1c9d
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
a7a1c9d
to
2e33d15
Compare
- Don't fail the installation validation if --encryption flag is not specified. It should behave the same way as if the flag is set to "disabled". - Return the resolved Helm chart from ResolveHelmChartVersion so that Helm can use the chart later. - Expose RESTClientGetter. Helm client needs it. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
2e33d15
to
a1c24f8
Compare
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
a1c24f8
to
03e2960
Compare
michi-covalent
changed the title
aanm
approved these changes
Mar 30, 2023
tklauser
reviewed
Mar 30, 2023
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
03e2960
to
385d2e8
Compare
This is an alternative implementation to manage Cilium installations. It uses Helm actions to manage Cilium instead of generating Kubernetes resources from the Helm chart and managing them using the Kubernetes APIs directly. These commands are disabled by default. Set CILIUM_CLI_MODE environment variable to "helm" to enable these commands. Ref: #1396 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/helminstall
branch
from
385d2e8
to
fab588f
Compare
nbusseneau
approved these changes
Mar 31, 2023
| @@ -22,7 +22,13 @@ jobs: | |||
| installation-and-connectivity: | |||
| runs-on: ubuntu-22.04 | |||
| timeout-minutes: 40 | |||
| strategy: | |||
| matrix: | |||
| mode: ["classic", "helm"] | |||
There was a problem hiding this comment.
Am I correct in that later on we will drop the classic mode and only have Helm available?
There was a problem hiding this comment.
yeah we'll gradually transition to the helm mode, and then deprecate the classic mode ✨
| - name: Install Cilium with IPsec Encryption | ||
| if: ${{ matrix.mode == 'helm' }} | ||
| run: | | ||
| kubectl create -n kube-system secret generic cilium-ipsec-keys \ |
There was a problem hiding this comment.
Can't we still have this handled by the CLI even in Helm mode?
There was a problem hiding this comment.
yeah we could. i do want to have a discussion first though and come up with a general guideline on how cilium-cli should handle resources that are not part of the helm chart.
on the one hand, these flags are very convenient. on the other hand, i think it's a very slippery slope. we might end up adding more and more logic to cilium-cli without carefully considering:
- what resources should be managed by cilium, and what resources should be managed by the user.
- if cilium should be managing the resource, why it's not part of the helm chart.
christarazi
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review commit by commit. there are 2 commits:
let's implement other commands in separate PRs to keep the PR size reasonable.
ref: #1396