install: Support --nodes-without-cilium in Helm install mode #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
christarazi
commented
Apr 10, 2023
christarazi
commented
- Fix quotation for Cilium schedule affinity
- install: Support --nodes-without-cilium in Helm install mode
Without this, the following error occurs when configuring `--nodes-without-cilium`: ``` Error: Unable to install Cilium: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Affinity: v1.Affinity.NodeAffinity: v1.NodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution: v1.NodeSelector.NodeSelectorTerms: []v1.NodeSelectorTerm: v1.NodeSelectorTerm.MatchExpressions: []v1.NodeSelectorRequirement: v1.NodeSelectorRequirement.Values: []string: ReadString: expects " or n, but found t, error found in #10 byte of ...|values":[true]}]}]}}|..., bigger context ...|ium.io/no-schedule","operator":"NotIn","values":[true]}]}]}},"podAntiAffinity":{"requiredDuringSched|... ``` Co-authored-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
changed the title
michi-covalent
approved these changes
Apr 10, 2023
christarazi
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes: #1498 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
christarazi
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes: #1498 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes: #1498 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
Fixes: cilium/cilium-cli#1498 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.