BGP: Introduce new cli to get bgp peering state

[harsimran-pabla]

This change introduces new BGP status CLI : cilium bgp peers. Status of BGP peers is returned from all or specific node in json or summary formats.

./cilium bgp peers --help
Gets BGP peering status from all nodes in the cluster

Usage:
  cilium bgp peers [flags]

Flags:
      --agent-pod-selector string   Label on cilium-agent pods to select with (default "k8s-app=cilium")
  -h, --help                        help for peers
      --node string                 Node from which BGP status will be fetched, omit to select all nodes
  -o, --output string               Output format. One of: json, summary (default "summary")
      --wait-duration duration      Maximum time to wait for result, default 1 minute (default 1m0s)

Signed-off-by: harsimran pabla hpabla@isovalent.com

[harsimran-pabla]

Example 1

Per node output :

> ./cilium bgp peers --node clab-bgp-cplane-demo-worker3 -o json
{
 "clab-bgp-cplane-demo-worker3": [
  {
   "families": [
    {
     "accepted": 11,
     "advertised": 1,
     "afi": "ipv4",
     "received": 11,
     "safi": "unicast"
    },
    {
     "afi": "ipv6",
     "safi": "unicast"
    }
   ],
   "local-asn": 65011,
   "peer-address": "10.0.0.2",
   "peer-asn": 65011,
   "session-state": "established",
   "uptime-nanoseconds": 422509145342
  }
 ]
}

> ./cilium bgp peers --node clab-bgp-cplane-demo-worker3
Node                           Local AS   Peer AS   Peer Address   Session State   Uptime   Family         Received   Advertised
clab-bgp-cplane-demo-worker3   65011      65011     10.0.0.2       established     7m5s     ipv4/unicast   11         1
                                                                                            ipv6/unicast   0          0

[harsimran-pabla]

Example 2

Output from 4 BGP nodes

 > ./cilium bgp peers
Node                                 Local AS   Peer AS   Peer Address   Session State   Uptime   Family         Received   Advertised
clab-bgp-cplane-demo-control-plane   65010      65010     10.0.0.1       established     6s       ipv4/unicast   11         1
                                                                                                  ipv6/unicast   0          0
clab-bgp-cplane-demo-worker          65010      65010     10.0.0.1       established     6s       ipv4/unicast   11         1
                                                                                                  ipv6/unicast   0          0
clab-bgp-cplane-demo-worker2         65011      65011     10.0.0.2       established     5s       ipv4/unicast   11         1
                                                                                                  ipv6/unicast   0          0
clab-bgp-cplane-demo-worker3         65011      65011     10.0.0.2       established     8s       ipv4/unicast   11         1
                                                                                                  ipv6/unicast   0          0

> ./cilium bgp peers -o json
{
 "clab-bgp-cplane-demo-control-plane": [
  {
   "families": [
    {
     "accepted": 11,
     "advertised": 1,
     "afi": "ipv4",
     "received": 11,
     "safi": "unicast"
    },
    {
     "afi": "ipv6",
     "safi": "unicast"
    }
   ],
   "local-asn": 65010,
   "peer-address": "10.0.0.1",
   "peer-asn": 65010,
   "session-state": "established",
   "uptime-nanoseconds": 15416378912
  }
 ],
 "clab-bgp-cplane-demo-worker": [
  {
   "families": [
    {
     "accepted": 11,
     "advertised": 1,
     "afi": "ipv4",
     "received": 11,
     "safi": "unicast"
    },
    {
     "afi": "ipv6",
     "safi": "unicast"
    }
   ],
   "local-asn": 65010,
   "peer-address": "10.0.0.1",
   "peer-asn": 65010,
   "session-state": "established",
   "uptime-nanoseconds": 15412779062
  }
 ],
 "clab-bgp-cplane-demo-worker2": [
  {
   "families": [
    {
     "accepted": 11,
     "advertised": 1,
     "afi": "ipv4",
     "received": 11,
     "safi": "unicast"
    },
    {
     "afi": "ipv6",
     "safi": "unicast"
    }
   ],
   "local-asn": 65011,
   "peer-address": "10.0.0.2",
   "peer-asn": 65011,
   "session-state": "established",
   "uptime-nanoseconds": 14422631014
  }
 ],
 "clab-bgp-cplane-demo-worker3": [
  {
   "families": [
    {
     "accepted": 11,
     "advertised": 1,
     "afi": "ipv4",
     "received": 11,
     "safi": "unicast"
    },
    {
     "afi": "ipv6",
     "safi": "unicast"
    }
   ],
   "local-asn": 65011,
   "peer-address": "10.0.0.2",
   "peer-asn": 65011,
   "session-state": "established",
   "uptime-nanoseconds": 17406343458
  }
 ]
}

[asauber]

Very clean implementation, LGTM. Perhaps we want a test that would flag changes to the summary format.

[harsimran-pabla]

@asauber Added test case to verify the format of summary output. Had to pull testify/require in vendor directory - so some more files are changed. Please take a look at latest commit for changes.

[asauber]

Thanks for the test. Looks great

[tklauser]

Code changes LGTM.

Could you please also update CODEOWNERS to assign bgp/ to @cilium/sig-bgp as follows?

diff --git a/CODEOWNERS b/CODEOWNERS
index d9bb8f5f2155..1ad7dcb11d5f 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -22,6 +22,7 @@
 /.github/kind-config*.yaml @cilium/ci-structure
 /.github/tools/ @cilium/ci-structure
 /.github/workflows/ @cilium/github-sec @cilium/ci-structure
+/bpf/ @cilium/sig-bgp
 /cmd/ @cilium/cli
 /clustermesh/ @cilium/sig-clustermesh
 /connectivity/ @cilium/cli

[ldelossa]

LGTM