connectivity: Make detected Cilium Agent version available for feature detection #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e detection Make detected Cilium Agent version available for feature detection and use it instead of trying to detect Cilium version from the agent image reference. This helps avoid failures like this when the image tag is not a semantic version (in this case image tag is "test"): connectivity test failed: unable to determine if KNP feature is enabled: failed to parse Cilium version test to semver Cilium agent version was already detected, this PR moves the detection a bit earlier to make it available for feature detection. Fixes: #1470 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
|
@sayboras This is why the tests fail to run on |
mhofstetter
reviewed
Apr 13, 2023
tklauser
approved these changes
Apr 13, 2023
mhofstetter
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make detected Cilium Agent version available for feature detection and use it instead of trying to detect Cilium version from the agent image reference. This helps avoid failures like this when the image tag is not a semantic version (in this case image tag is "test"):
Cilium agent version was already detected, this PR moves the detection a bit earlier to make it available for feature detection.
Fixes: #1470
Fixes: #1507