misc: get rid of Go label breaks & gotos #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go's label breaks should be avoided where possible. This commit replaces label breaks with the usage of extracted functions. Beside getting rid of the label break, they improve readability too. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Go's goto statement should be avoided where possible. This commit replaces goto statements to labels with the usage of extracted functions or for loops. Beside getting rid of the goto statement, this approach improves the readability. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
commented
Apr 13, 2023
tklauser
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usages of Go label breaks & goto. IMO they should be avoided whenever possible.
Most often, they are replaced with introducing an extracted function. Beside getting rid of the statements itself - this approach also improves readability.