cli: adapt helm chart cleanup of deprecated hubble values #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
force-pushed
the
pr/mhofstetter/fix-hubble-peer-tls
branch
from
fede25c
to
d3fe1c3
Compare
Deprecated Cilium Helm Chart values have been removed in the PR cilium/cilium#24214. Installing Cilium (`cilium install`) & enabling hubble (`cilium hubble enable`) will break the connectivity from the hubble relay to the peer service (`Failed to create peer client for peers synchronization...`). This will consequently also fail the connectivity tests with the following error: `Timeout waiting for flow listener to become ready`. We need to set `tls.ca.cert` & `tls.ca.key` during `cilium hubble enable` to use the same CA cert. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/fix-hubble-peer-tls
branch
from
d3fe1c3
to
19866a4
Compare
kaworu
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated Cilium Helm Chart values have been removed in the PR cilium/cilium#24214 - this change specifically.
Installing Cilium (
cilium install --chart-directory install/kubernetes/cilium) & enabling hubble (cilium hubble enable --chart-directory install/kubernetes/cilium) will break the connectivity from the hubble relay to the peer service (Failed to create peer client for peers synchronization...).This will consequently also fail the connectivity tests with the following error:
Timeout waiting for flow listener to become ready.We need to set
tls.ca.cert&tls.ca.keyduringcilium hubble enableto use the same CA cert.Occurred in the CIlium Integration Tests of Cilium Proxy where latest Cilium CLI gets used in combination with latest Cilium version: https://github.com/cilium/proxy/actions/runs/4742847574/jobs/8421623603