Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: Add test cases for Ingress #1533

Merged
merged 2 commits into from
Apr 26, 2023
Merged

connectivity: Add test cases for Ingress #1533

merged 2 commits into from
Apr 26, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 24, 2023 •
edited

Description

This commit is to improve the Ingress coverage with the below cases:

  • no policy, requests should pass.
  • default denied for all endpoints, request should fail.
  • default denied for all endpoints, but allow Ingress identity, requests
    should pass.

Relates: cilium/cilium#24826

Signed-off-by: Tam Mach tam.mach@cilium.io

Testing

Testing was done locally

$ ./cilium connectivity test --test ingress-service
...
[=] Test [pod-to-ingress-service]
..
[=] Test [pod-to-ingress-service-deny-all]
..
[=] Test [pod-to-ingress-service-allow-ingress-identity]
..

[=] Skipping Test [dns-only]

[=] Skipping Test [to-fqdns]

✅ All 3 tests (6 actions) successful, 44 tests skipped, 0 scenarios skipped.

@sayboras
connectivity: Add Ingress resource for echo service
06ffae5 
This is for preparation of subsequent commits, which will perform
Ingress connectivity test. The same echo-same-node service is used
as Ingress back-end.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
connectivity: Add Ingress related tests
e72270b 
This commit is to improve the Ingress coverage with below cases:

- no policy, requests should pass.
- default denied for all endpoints, request should fail.
- default denied for all endpoints, but allow Ingress identity, requests
  should pass.

Relates: cilium/cilium#24826

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras temporarily deployed to ci April 24, 2023 05:49 — with GitHub Actions Inactive
@sayboras sayboras added the dont-merge/preview-only Only for preview or testing, don't merge it. label Apr 24, 2023
@sayboras sayboras mentioned this pull request Apr 24, 2023
Closed
2 tasks
@jrajahalme jrajahalme mentioned this pull request Apr 24, 2023
Merged
jrajahalme
jrajahalme approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Apr 24, 2023
@sayboras sayboras marked this pull request as ready for review April 24, 2023 16:33
@sayboras sayboras requested review from a team as code owners April 24, 2023 16:33
@sayboras sayboras requested a review from squeed April 24, 2023 16:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@michi-covalent michi-covalent merged commit c11d062 into cilium:main Apr 26, 2023
12 checks passed
@sayboras sayboras deleted the tam/Ingress-identity-tests branch April 26, 2023 14:25
sayboras added a commit to cilium/cilium that referenced this pull request Nov 13, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
c557312 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Nov 13, 2023
Merged
sayboras added a commit to cilium/cilium that referenced this pull request Nov 14, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
b04e17e 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 14, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
d978158 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
4be10b4 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
561ea1c 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
a7a3fcf 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
aanm pushed a commit to cilium/cilium that referenced this pull request Nov 20, 2023
@sayboras @aanm
gha: Enable Ingress Controller tests in conformance-e2e
c8ee339 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
@sayboras @pjablonski123
gha: Enable Ingress Controller tests in conformance-e2e
18a25c8 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
gandro pushed a commit to cilium/cilium that referenced this pull request Mar 28, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
c71fde4 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro pushed a commit to cilium/cilium that referenced this pull request Mar 28, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
073aa5c 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@sayboras sayboras mentioned this pull request Apr 2, 2024
Closed
gandro pushed a commit to cilium/cilium that referenced this pull request Apr 8, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
f4b4dbe 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
lmb pushed a commit to cilium/cilium that referenced this pull request Apr 9, 2024
@sayboras @lmb
gha: Enable Ingress Controller tests in conformance-e2e
bf6bf13 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @squeed @jrajahalme @michi-covalent