Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CiliumCIDRGroup CRD #1537

Merged
merged 1 commit into from
May 18, 2023
Merged

Add support for CiliumCIDRGroup CRD #1537

merged 1 commit into from
May 18, 2023

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Apr 25, 2023 •
edited

Now that Cilium implemented support for CiliumCIDRGroups, let's support dumping it in sysdump.

Fixes: #1538

@christarazi christarazi temporarily deployed to ci April 25, 2023 23:23 — with GitHub Actions Inactive
@christarazi christarazi changed the title pr/christarazi/cidrgroup crd Add support for CiliumCIDRGroup CRD Apr 25, 2023
@christarazi christarazi marked this pull request as ready for review April 25, 2023 23:23
@christarazi christarazi requested review from a team as code owners April 25, 2023 23:23
@christarazi christarazi temporarily deployed to ci April 25, 2023 23:29 — with GitHub Actions Inactive
@christarazi christarazi temporarily deployed to ci April 26, 2023 04:39 — with GitHub Actions Inactive
@christarazi christarazi force-pushed the pr/christarazi/cidrgroup-crd branch from a1aec49 to 5101ca1 Compare May 1, 2023 19:27
@christarazi christarazi temporarily deployed to ci May 1, 2023 19:27 — with GitHub Actions Inactive
@joestringer joestringer added the needs-rebase This PR needs to be rebased because it has merge conflicts. label May 5, 2023
rolinh
rolinh approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor changes lgtm

@christarazi
sysdump: Add support for CiliumCIDRGroup CRD
75da2b2 
Now that Cilium implemented support for CiliumCIDRGroups, let's support
dumping it in sysdump.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/cidrgroup-crd branch from 5101ca1 to 75da2b2 Compare May 17, 2023 23:04
@christarazi christarazi temporarily deployed to ci May 17, 2023 23:04 — with GitHub Actions Inactive
@christarazi christarazi merged commit 924128e into main May 18, 2023
17 checks passed
@christarazi christarazi deleted the pr/christarazi/cidrgroup-crd branch May 18, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@rolinh rolinh rolinh approved these changes

@asauber asauber asauber approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
needs-rebase This PR needs to be rebased because it has merge conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for extracting CiliumCIDRGroup CRD in sysdump
5 participants
@christarazi @joestringer @rolinh @asauber @youngnick