connectivity: Retry getting the policy revision #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Apr 26, 2023
pchaigno
force-pushed
the
pr/pchaigno/retry-get-policy-revision
branch
from
773b73b
to
b1fa187
Compare
This commit adds some retry logic to the policy revision retrieval in case of a timeout. Such timeouts can happen because of simple connectivity blips. This piece of code has been identified as fairly critical [1]. We attempt to retrieve these policy revisions when applying and deleting policies. If we fail to retrieve the policy revision, we fail the whole policy deletion. That can lead to failures in subsequent tests because of the leftover policy. 1 - #1260 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/retry-get-policy-revision
branch
from
b1fa187
to
abeac63
Compare
squeed
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some retry logic to the policy revision retrieval in case of a timeout. Such timeouts can happen because of simple connectivity blips.
This piece of code has been identified as fairly critical [1]. We attempt to retrieve these policy revisions when applying and deleting policies. If we fail to retrieve the policy revision, we fail the whole policy deletion. That can lead to failures in subsequent tests because of the leftover policy.
1 - #1260
Fixes: #1260.