connectivity/tests: omit IPs and vendor name from test names #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construct the test names using the generic string "external" and the IP
that is actually used, e.g. using the external IP 1.2.3.4 would lead to
the test being named "external-1234".
Also change all references to specific IP addresses from the tests and
manifests and replace them by External{,Other}{IP,CIDR} placeholders.
Fixes #1542
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/connectivity-world-test-name
branch
from
742f724
to
65064ab
Compare
tklauser
changed the title
squeed
approved these changes
Apr 27, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct the test names using the generic string "external" and the IP
that is actually used, e.g. using the external IP 1.2.3.4 would lead to
the test being named "external-1234".
Also change all references to specific IP addresses from the tests and
manifests and replace them by External{,Other}{IP,CIDR} placeholders.
Fixes #1542