Support for dedicated Cilium Envoy DaemonSet #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
commented
Apr 27, 2023
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-daemonset
branch
from
685ec7a
to
eb4f3e6
Compare
11 tasks
mhofstetter
added
the
dont-merge/blocked
|
setting Of course status & sysdump still works even if Envoy isn't deployed as DaemonSet - it's for the sake of agreeing on resource naming etc. |
squeed
reviewed
May 9, 2023
squeed
reviewed
May 9, 2023
|
Seems reasonable! And I'm glad that you don't have to muck about with adding lots of new files to install mode :-) |
mhofstetter
removed
the
dont-merge/blocked
|
removing label |
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-daemonset
branch
from
eb4f3e6
to
1845199
Compare
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-daemonset
branch
from
1845199
to
c5d635d
Compare
|
rebased to |
jrajahalme
approved these changes
May 17, 2023
|
@squeed would you mind taking a final look? |
This commit reflects the newly added cilium envoy daemonset in the cilium cli status. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
With this commit, the SysDumpCollectors collects the logs from the newly introduced Cilium Envoy Pods. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
With this commit, `cilium sysdump` collects the DaemonSet & ConfigMap of the Cilium Envoy. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
To prevent irritation around the disabled "Envoy DaemonSet" in the status - this commit replaces the default `disabled` with `disabled (using embedded mode)` in case of the Envoy DaemonSet status. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-daemonset
branch
from
4e74b7b
to
f1bea9f
Compare
|
rebased to |
squeed
approved these changes
May 23, 2023
|
MLH sleeping? 馃 adding label |
mhofstetter
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/cilium#25081 adds support for deploying Cilium's L7 Proxy (Envoy) to be deployed in its own DaemonSet instead of running it in the same container as the Cilium Agent. Currently, it needs to be explicitly enabled via helm value
envoy.enabled=trueThis PR adds support for the new Envoy DaemonSet in the Cilium CLI.
Installation works out of the box with the newly introduced helm CLI mode 馃帀
Classic mode isn't supported for the time being and needs to be discussed.