connectivity: test accessing NodePort from outside with L7 policy #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
force-pushed
the
gray/nodeport-l7-test
branch
from
4a7ea58
to
aadde2f
Compare
jschwinger233
changed the title
jschwinger233
force-pushed
the
gray/nodeport-l7-test
branch
from
aadde2f
to
a936401
Compare
pchaigno
reviewed
Apr 27, 2023
jschwinger233
force-pushed
the
gray/nodeport-l7-test
branch
from
a936401
to
a71ed48
Compare
This test case covers cilium/cilium#21954. A new policy `echo-ingress-l7-policy-from-anywhere` is added to allow HTTP GET / on echo pods from outside. Use `cilium connectivity test --test north-south-loadbalancing --datapath` to run this test. Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/nodeport-l7-test
branch
from
a71ed48
to
4ac1a48
Compare
|
Please note cilium can't pass the new added test case until cilium/cilium#24882 is merged. |
Nice! I assume you ran the tests locally with the fix? |
Yes! |
brb
approved these changes
Apr 28, 2023
brb
added
dont-merge/blocked
|
Added |
pchaigno
removed
the
dont-merge/blocked
pchaigno
approved these changes
May 2, 2023
tommyp1ckles
added a commit
to tommyp1ckles/cilium
that referenced
this pull request
May 2, 2023
Changes in c1a0dba may have introduced flakes for this set of tests when attempting to reach NodePort from outside the cluster. A replacement test is being added to cilium cli connectivity tests: cilium/cilium-cli#1547 Quarantine this test for now until we can remove it. Addresses: cilium#25119 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
squeed
approved these changes
May 2, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tommyp1ckles
added a commit
to cilium/cilium
that referenced
this pull request
May 4, 2023
Changes in c1a0dba may have introduced flakes for this set of tests when attempting to reach NodePort from outside the cluster. A replacement test is being added to cilium cli connectivity tests: cilium/cilium-cli#1547 Quarantine this test for now until we can remove it. Addresses: #25119 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
jschwinger233
added a commit
to jschwinger233/cilium
that referenced
this pull request
May 26, 2023
The test case was introduced to cover issue cilium#21954, but it turned out the test is buggy and caused a number of CI flakes (cilium#25119). Consequently, PR cilium#25236 put the test case under quarantine. This commit removes that problematic test, as the target scenario has been covered by connectivity test in cilium-cli (cilium/cilium-cli#1547). Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
brb
pushed a commit
to cilium/cilium
that referenced
this pull request
May 26, 2023
The test case was introduced to cover issue #21954, but it turned out the test is buggy and caused a number of CI flakes (#25119). Consequently, PR #25236 put the test case under quarantine. This commit removes that problematic test, as the target scenario has been covered by connectivity test in cilium-cli (cilium/cilium-cli#1547). Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
sayboras
pushed a commit
to sayboras/cilium
that referenced
this pull request
May 29, 2023
[ upstream commit eb5bf06 ] The test case was introduced to cover issue cilium#21954, but it turned out the test is buggy and caused a number of CI flakes (cilium#25119). Consequently, PR cilium#25236 put the test case under quarantine. This commit removes that problematic test, as the target scenario has been covered by connectivity test in cilium-cli (cilium/cilium-cli#1547). Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
julianwiedmann
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 2, 2023
[ upstream commit eb5bf06 ] The test case was introduced to cover issue #21954, but it turned out the test is buggy and caused a number of CI flakes (#25119). Consequently, PR #25236 put the test case under quarantine. This commit removes that problematic test, as the target scenario has been covered by connectivity test in cilium-cli (cilium/cilium-cli#1547). Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case covers cilium/cilium#21954.
A new policy
echo-ingress-l7-policy-from-anywhereis added to allow HTTP GET / on echo pods from outside.Use
cilium connectivity test --test north-south-loadbalancing --datapathto run this test.Signed-off-by: Zhichuan Liang <gray.isovalent.com>