Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s deps to v1.27.1 #1548

Merged
merged 3 commits into from
May 3, 2023
Merged

Update k8s deps to v1.27.1 #1548

merged 3 commits into from
May 3, 2023

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser tklauser requested review from a team as code owners April 27, 2023 12:14
@tklauser tklauser requested review from rolinh and squeed April 27, 2023 12:14
@tklauser tklauser temporarily deployed to ci April 27, 2023 12:14 — with GitHub Actions Inactive
@tklauser tklauser temporarily deployed to ci April 27, 2023 14:49 — with GitHub Actions Inactive
@tklauser tklauser temporarily deployed to ci April 27, 2023 14:57 — with GitHub Actions Inactive
@tklauser tklauser temporarily deployed to ci April 28, 2023 08:16 — with GitHub Actions Inactive
@tklauser
go.mod, vendor: update k8s deps to v1.27.1
e686037 
Update k8s deps to k8s 1.27.1, i.e. module version v0.27.1.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
connectivity/check: use existing label constants from corev1
138d415 
Use the predefined corev1 constants instead of open-coding them.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
sysdump: replace deprecated methods
5f72026 
Use k8s.io/apimachinery/pkg/util/wait.PollUntilContextTimeout instead of
.PollWithContext. The latter is deprecated in favor of the former.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser temporarily deployed to ci April 28, 2023 12:12 — with GitHub Actions Inactive
@tklauser tklauser merged commit e1d57b3 into main May 3, 2023
12 of 13 checks passed
@tklauser tklauser deleted the pr/tklauser/k8s-bump-1.27 branch May 3, 2023 08:42
@michi-covalent
Copy link
Contributor

@tklauser i'm wondering it might be a good idea to keep k8s.io/api version in sync between cilium/cilium and cilium/cilium-cli` 👀

https://github.com/cilium/cilium/blob/v1.14.0-snapshot.2/go.mod#L113
https://github.com/cilium/cilium-cli/blob/main/go.mod#L32

@tklauser
Copy link
Member Author

Agree keeping k8s version here synchronized with the bump in cilium/cilium.

The intention of the PR was to bump it in preparation for the version bump in cilium/cilium (cilium/cilium#24837) in the next snapshot. Unfortunately, that PR had to be reverted due to CI issues, but we didn't revert in cilium/cilium-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh is a code owner automatically assigned from cilium/vendor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tklauser @michi-covalent @squeed