sysdump: Fix writing to absolute path #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing the sysdump to an absolute path doesn't work because we always
append the current directory to the output filename:
$ ./cilium sysdump --output-filename /tmp/cilium-sysdump
[...]
✅ The sysdump has been saved to /home/paul/cilium-cli/tmp/cilium-sysdump.zip
Let's remove the code that does that.
Fixes: 77a1f23 ("sysdump: initial sysdump implementation")
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/sysdump-fix-absolute-paths
branch
from
688fa43
to
34e04a3
Compare
tklauser
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Running ./cilium sysdump --output-filename /tmp/cilium-sysdump built from this PR I get:
% ./cilium sysdump --output-filename /tmp/cilium-sysdump
🔍 Collecting sysdump with cilium-cli version: v0.14.0-2-g34e04a38017f, args: [sysdump --output-filename /tmp/cilium-sysdump]
[...]
✅ The sysdump has been saved to /tmp/cilium-sysdump.zip
I'd expect the file to be written to /tmp/cilium-sysdump/cilium-sysdump.zip though.
tklauser
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Sorry I was confused, never mind my previous comment, --output-filename should actually be the filename without extension:
--output-filename string The name of the resulting file (without extension)
'<ts>' can be used as the placeholder for the timestamp (default "cilium-sysdump-<ts>")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing the sysdump to an absolute path doesn't work because we always append the current directory to the output filename:
Let's remove the code that does that.
Fixes: 77a1f23 ("sysdump: initial sysdump implementation")