-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectivity: add basic egress gateway test #1555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 1, 2023 08:56
0d25383
to
4e8b9ec
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 1, 2023 09:29
4e8b9ec
to
d6bebb2
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 1, 2023 10:11
d6bebb2
to
f03b5e0
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 1, 2023 10:33
f03b5e0
to
a008d6d
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 09:08
a008d6d
to
d0b22f7
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 09:14
d0b22f7
to
ba2f150
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 09:23
ba2f150
to
048420c
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 09:34
048420c
to
ee87948
Compare
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
add a new echo-external deployment for a JSON mock pod targeting all external nodes (i.e. nodes that are not running Cilium) Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 12:51
ee87948
to
44dff90
Compare
jibi
changed the title
WIP: Add initial egress gateway tests
connectivity: add basic egress gateway test
May 2, 2023
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 12:55
44dff90
to
7cfdc17
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 12:57
7cfdc17
to
ea8c6b2
Compare
this commit adds a new method to the check package, WithCiliumEgressGatewayPolicy(), which can be used to apply one or more egress gateway policies in the context of a given test. The helper does not wait for the policies to be enforced so it will be up the individual tests to ensure that (i.e. BPF entries for the policy map are set). Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 2, 2023 12:58
ea8c6b2
to
6ef2dc1
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 4, 2023 07:47
243579e
to
7f6e859
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 4, 2023 08:48
7f6e859
to
0fbb1d9
Compare
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 4, 2023 09:29
0fbb1d9
to
e25c9dd
Compare
brb
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍕 🚀
nebril
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci-structure bits LGTM
tklauser
approved these changes
May 5, 2023
aanm
requested changes
May 5, 2023
This commit adds a first basic egress gateway test. Given the cegp-sample CiliumEgressGatewayPolicy targeting: - a couple of client pods (kind=client) as source - the 0.0.0.0/0 destination CIDR - kind-worker2 as gateway node the test simply ensures that traffic from both clients reaches the echo-external service with the egress IP of the gateway node. Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Use the node that runs the client pod with the other=client label as egress gateway rather than hardcoding kind-worker2 Signed-off-by: Gilberto Bertin <jibi@cilium.io>
deploying the connectivity test twice on 2 different namespaces causes some issue for the echo-external pod, which uses the host network namespace and exposes a host port, so just reuse the same namespace for both tests. Relates: 3939c61 Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi
force-pushed
the
pr/jibi/egressgw-tests
branch
from
May 5, 2023 10:43
e25c9dd
to
af55b73
Compare
aanm
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first basic egress gateway test.
Given the cegp-sample CiliumEgressGatewayPolicy targeting:
the test simply ensures that traffic from both clients reaches the echo-external service with the egress IP of the gateway node