Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm mode: Make Helm chart repository configurable #1560

Merged
merged 1 commit into from
May 2, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented May 1, 2023

Add --repository flag in helm mode install / upgrade commands to override
the default https://helm.cilium.io repository.

I intentionally avoided adding this flag to the classic mode since it's
being deprecated in the next minor release (v0.15). The behavior of the
classic mode is unchanged in this pull request.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent michi-covalent temporarily deployed to ci May 1, 2023 21:25 — with GitHub Actions Inactive
@michi-covalent michi-covalent temporarily deployed to ci May 1, 2023 21:31 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review May 1, 2023 22:47
@michi-covalent michi-covalent requested a review from a team as a code owner May 1, 2023 22:47
@michi-covalent michi-covalent marked this pull request as draft May 2, 2023 04:12
Add --repository flag in helm mode install / upgrade commands to override
the default https://helm.cilium.io repository.

I intentionally avoided adding this flag to the classic mode since it's
being deprecated in the next minor release (v0.15). The behavior of the
classic mode is unchanged in this pull request.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci May 2, 2023 04:18 — with GitHub Actions Inactive
@michi-covalent michi-covalent changed the title helm mode: Make Helm chart registry configurable helm mode: Make Helm chart repository configurable May 2, 2023
@michi-covalent michi-covalent marked this pull request as ready for review May 2, 2023 04:19
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 2, 2023
@michi-covalent
Copy link
Contributor Author

the button is green ✅

@michi-covalent michi-covalent merged commit cf1b864 into main May 2, 2023
13 checks passed
@michi-covalent michi-covalent deleted the pr/michi/letsgo branch May 2, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants