Add GatewayAPI resources to sysdump #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
approved these changes
May 3, 2023
|
Got a lint failure: |
|
Is there any chance that there is secret data that will need to be scrubbed? I dunno, I always think of Ingress and brethren as having scary annotations. |
squeed
approved these changes
May 3, 2023
|
No, we've specifically designed Gateway API to only use structured data, and to keep secret stuff in Secrets. I hate annotations for Ingress stuff too. |
This adds all GatewayAPI objects to the sysdump as well as the IngressClass object. This will be helpful for troubleshooting GatewayAPI related issues. The objects are dumped into YAML if available prefixed with gatewayapi- for ease of use. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/sysdump-gwapi
branch
from
8f02980
to
8d0a547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all GatewayAPI objects to the sysdump as well as the IngressClass object. This will be helpful for troubleshooting GatewayAPI related issues.
The objects are dumped into YAML if available prefixed with gatewayapi- for ease of use.
Fixes #1567