Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OCI repositories #1576

Merged
merged 1 commit into from
May 5, 2023
Merged

Handle OCI repositories #1576

merged 1 commit into from
May 5, 2023

Conversation

michi-covalent
Copy link
Contributor

Tweak newChartFromRemoteWithCache() to support OCI repos:

  • chartRef must be the full OCI repository path.
  • RepoURL must be empty.
  • RegistryClient must be initialized.

Tweak newChartFromRemoteWithCache() to support OCI repos:

- chartRef must be the full OCI repository path.
- RepoURL must be empty.
- RegistryClient must be initialized.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci May 4, 2023 17:40 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review May 4, 2023 18:31
@michi-covalent michi-covalent requested a review from a team as a code owner May 4, 2023 18:31
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michi-covalent michi-covalent merged commit 0fd7bf3 into main May 5, 2023
14 checks passed
@michi-covalent michi-covalent deleted the pr/michi/oci2 branch May 5, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants