Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite: disable KNP tests when endpoint routes and IPv6 are enabled #1584

Merged
merged 2 commits into from
May 8, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented May 8, 2023

disable:

  • client-ingress-knp
  • echo-ingress-knp
  • client-egress-knp
  • client-egress-expression-knp

as the tests are currently failing with this configuration.

Issue tracked in #1585.

test run on Cilium main branch: https://github.com/cilium/cilium/actions/runs/4914096880/jobs/8775022204?pr=25194

@jibi jibi added the area/CI Continuous Integration testing issue or flake label May 8, 2023
@jibi jibi temporarily deployed to ci May 8, 2023 09:21 — with GitHub Actions Inactive
connectivity/suite.go Outdated Show resolved Hide resolved
@jibi jibi force-pushed the pr/jibi/disable-knp-endpointroutes-tests branch from 2f378f3 to e1c8deb Compare May 8, 2023 09:32
@jibi jibi temporarily deployed to ci May 8, 2023 09:32 — with GitHub Actions Inactive
@jibi jibi changed the title suite: disable KNP tests when endpoint routes is enabled suite: disable KNP tests when endpoint routes and IPv6 are enabled May 8, 2023
jibi added 2 commits May 8, 2023 12:11
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
disable:
* client-ingress-knp
* echo-ingress-knp
* client-egress-knp
* client-egress-expression-knp

as the tests are currently failing with this configuration.

Issue tracked in #1585.

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi force-pushed the pr/jibi/disable-knp-endpointroutes-tests branch from e1c8deb to bfa5e1b Compare May 8, 2023 10:19
@jibi jibi temporarily deployed to ci May 8, 2023 10:19 — with GitHub Actions Inactive
@jibi jibi marked this pull request as ready for review May 8, 2023 10:43
@jibi jibi requested a review from a team as a code owner May 8, 2023 10:43
@jibi jibi requested a review from nathanjsweet May 8, 2023 10:43
@pchaigno
Copy link
Member

pchaigno commented May 8, 2023

Asking for an ack from @jschwinger233 given #1585 (comment).

@jibi jibi requested a review from tklauser May 8, 2023 11:51
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser merged commit d2bac22 into main May 8, 2023
15 checks passed
@tklauser tklauser deleted the pr/jibi/disable-knp-endpointroutes-tests branch May 8, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants