Add hooks to use cilium-cli as a package #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
force-pushed
the
pr/pippolo84/main-hooks
branch
from
aa6252e
to
dc880c2
Compare
This allows building a version of cilium-cli externally with extended tests and other functionalities. Currently, cilium-cli may be extended with additional connectivity tests and sysdump tasks. Signed-off-by: Jussi Maki <jussi@isovalent.com>
WithSetupFunc allows to register callbacks to be executed right before the test begin, as part of the initial setup. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Expose the clusters clients to give access to k8s objects to custom setup callbacks. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
The previously added WithSetupFunc allows to register additional setup callbacks that may modify the k8s objects in a test scenario. WithFinalizer allows to register a finalizer to perform any needed cleanup. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Expose package template methods to allow connectivity test hooks rendering yaml templates. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
GetTest allows to fetch an already existing test by its name. This may be useful when a connectivity test hook wants to extend a test adding a scenario. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/main-hooks
branch
from
dc880c2
to
d9e9342
Compare
|
multi cluster failure: https://github.com/cilium/cilium-cli/actions/runs/5015953697/jobs/8992202981?pr=1609#step:20:70 looks like some random transient error. re-triggering: |
|
aks: filed #1643 |
asauber
approved these changes
May 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
who am i to argue with maintainer's little helper. it says ready to merge, i merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building a version of cilium-cli externally with extended connectivity tests and sysdump tasks.