connectivity: Skip IPv6 requests in north-south-loadbalancing-with-l7-policy when running on < 1.14.0 Cilium #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
force-pushed
the
gray/skip-ns
branch
from
2000b3d
to
39fab92
Compare
|
Ran |
brb
reviewed
May 15, 2023
connectivity/tests/service.go
Outdated
| // Skip IPv6 requests when running on <1.14.0 Cilium with CNPs | ||
| if check.GetIPFamily(addr.Address) == check.IPFamilyV6 && | ||
| versioncheck.MustCompile("<1.14.0")(t.Context().CiliumVersion) && | ||
| len(t.CiliumNetworkPolicies()) > 0 { |
There was a problem hiding this comment.
Please don't do my mistakes - please check t.knps too (#1587) 😅
jschwinger233
force-pushed
the
gray/skip-ns
branch
from
39fab92
to
af19916
Compare
brb
approved these changes
May 18, 2023
connectivity/check/context.go
Outdated
| @@ -705,6 +705,7 @@ func (ct *ConnectivityTest) CurlCommand(peer TestPeer, ipFam IPFamily, opts ...s | |||
| peer.Scheme(), | |||
| net.JoinHostPort(peer.Address(ipFam), fmt.Sprint(peer.Port())), | |||
| peer.Path())) | |||
| println(strings.Join(cmd, " ")) | |||
There was a problem hiding this comment.
Sorry - - I should have checked my PR
…-policy when running on < 1.14.0 Cilium cilium/cilium#21954 for the IPv6 path was resolved only for v1.14, but not for v1.13. In order to be able to run the latest connectivity tests on v1.13, we need to skip curl requests to the IPv6 addresses in that particular test. Fixes: cilium#1627 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/skip-ns
branch
from
af19916
to
329f3d0
Compare
julianwiedmann
added a commit
that referenced
this pull request
Mar 19, 2024
#1629 initially limited the IPv6 test to v1.14, as v1.13 was missing some functionality. But now that v1.13 has cilium/cilium#31161, the IPv6 path should actually work. So let's extend the test coverage. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/cilium#21954 for the IPv6 path was resolved only for v1.14, but not for v1.13. In order to be able to run the latest connectivity tests on v1.13, we need to skip curl requests to the IPv6 addresses in that particular test.
Fixes: #1627
Signed-off-by: Zhichuan Liang <gray.isovalent.com>