sysdump: Don't save cilium-etcd-secrets #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redacting sensitive info is error prone. For example, there was a bug that recently got fixed in #1631 where the cilium-cli wasn't redacting fields in last-applied-configuration. The purpose of this check is to indicate whether cilium-etcd-secrets exists, so let's just do that without actually storing the secret in sysdump. With this change, there will be a line in cilium-sysdump.log. If the secret exists: % grep cilium-etcd-secrets cilium-sysdump.log 馃攳 Checking if cilium-etcd-secrets exists in kube-system namespace Secret "cilium-etcd-secrets" found in namespace "kube-system" If the secret does not exist: % grep cilium-etcd-secrets cilium-sysdump.log 馃攳 Checking if cilium-etcd-secrets exists in kube-system namespace Secret "cilium-etcd-secrets" not found in namespace "kube-system" - this is expected when using the CRD KVStore Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
asauber
approved these changes
May 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redacting sensitive info is error prone. For example, there was a bug that recently got fixed in #1631 where the cilium-cli wasn't redacting fields in last-applied-configuration.
The purpose of this check is to indicate whether cilium-etcd-secrets exists, so let's just do that without actually storing the secret in sysdump. With this change, there will be a line in cilium-sysdump.log.
If the secret exists:
If the secret does not exist: