helm mode: Add external workloads test coverage #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's failing in helm mode because cilium-cli/clustermesh/certs.go Line 139 in 64bd65c need to look into whether this is configurable via helm 👀 |
michi-covalent
force-pushed
the
pr/michi/external
branch
from
4683483
to
537ee2b
Compare
|
✅ https://github.com/cilium/cilium-cli/actions/runs/5009483637/jobs/8978707657?pr=1640 removing the temporary commit and marking it ready for review |
michi-covalent
force-pushed
the
pr/michi/external
branch
from
fab997f
to
7c301c3
Compare
christarazi
approved these changes
May 18, 2023
giorio94
reviewed
May 18, 2023
michi-covalent
force-pushed
the
pr/michi/external
branch
from
7c301c3
to
3204aec
Compare
|
✅ successful run: https://github.com/cilium/cilium-cli/actions/runs/5018586743?pr=1640 removing the temporary commit. |
michi-covalent
force-pushed
the
pr/michi/external
branch
from
3204aec
to
978287c
Compare
Add --enable-external-workloads flag to "clustermesh enable" command to set externalWorkloads.enabled to true. With this Helm value set to true, clustermesh-apiserver-client-cert secret gets created. This certificate is used by external workloads. The certificate name is clustermesh-apiserver-external-workload-cert in classic mode for some reason. Add getExternalWorkloadCertName() function that returns the correct cert name depending on which mode the CLI is in. Co-authored-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Ref: #1625 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/external
branch
from
430139b
to
3f70b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1625