connectivity: add property flag for junit #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
approved these changes
May 24, 2023
viktor-kurchenko
approved these changes
May 24, 2023
tklauser
changed the title
tklauser
approved these changes
May 25, 2023
|
@brlbil this PR picked up a conflict. Could you please rebase? |
tklauser
added
the
needs-rebase
These changes add a new key=value flag `--junit-property` Provided key value pairs will be added to the generated junit file. Properties will be required to distinguish junit test names in `cilium` connectivity test reporting. Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/add-junit-property-flag
branch
from
bf895e4
to
fb704a7
Compare
tklauser
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new key=value flag
--junit-propertyProvided key value pairs will be added to the generated junit file.
Properties will be required to distinguish junit test names in
ciliumconnectivity test reporting.The new flag is added to the kind test.