Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Change multicluster provisioning to none blocking mode #1680

Merged
merged 1 commit into from
May 31, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented May 31, 2023

The multicluster test set up two clusters in blocking mode sequentially. Every cluster provisioning takes 4 to 5 min.
This commit changes provisioning to none blocking mode and adds a step to wait for provisioning to finish.

This change would cut the run time by 4 to 5 min.

The link to the run, one failed and successful
but both of the installation steps are successful, which is what counts here.

@brlbil brlbil temporarily deployed to ci May 31, 2023 12:48 — with GitHub Actions Inactive
Multicluster test set up two clusters in blocking mode in sequentially.
Every cluster provisioning takes 4 to 5 min.
This commit changes provisioning to none blocking mode and adds
a step to wait for provisioning to finish.

This change would cut the run time by 4 to 5 min.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-none-blocking-multicluster-provisioning branch from 804e350 to d19bbab Compare May 31, 2023 13:25
@brlbil brlbil temporarily deployed to ci May 31, 2023 13:25 — with GitHub Actions Inactive
@brlbil brlbil force-pushed the pr/brlbil/ci-none-blocking-multicluster-provisioning branch from d19bbab to c26cb05 Compare May 31, 2023 14:01
@brlbil brlbil temporarily deployed to ci May 31, 2023 14:01 — with GitHub Actions Inactive
@brlbil brlbil marked this pull request as ready for review May 31, 2023 14:04
@brlbil brlbil requested review from a team as code owners May 31, 2023 14:04
@brlbil brlbil added the area/CI Continuous Integration testing issue or flake label May 31, 2023
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@brlbil brlbil added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 31, 2023
@tklauser tklauser merged commit 6ae517c into main May 31, 2023
18 of 19 checks passed
@tklauser tklauser deleted the pr/brlbil/ci-none-blocking-multicluster-provisioning branch May 31, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants