Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysdump: gather tetragon namespaced policies #1694

Merged
merged 1 commit into from
Jun 9, 2023
Merged

sysdump: gather tetragon namespaced policies #1694

merged 1 commit into from
Jun 9, 2023

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jun 2, 2023

Recently, tetragon added namespaced tracing policies (TracingPolicyNamespaced). Collect this as well.

Tested manually on a kind cluster.

@kkourt kkourt requested review from a team as code owners June 2, 2023 12:05
@kkourt kkourt requested review from joamaki and squeed June 2, 2023 12:05
@kkourt kkourt temporarily deployed to ci June 2, 2023 12:05 — with GitHub Actions Inactive
squeed
squeed requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some build failures; you'll need to update some test files as well.

@kkourt
sysdump: gather tetragon namespaced policies
68da562 
Recently, tetragon added namespaced tracing policies (TracingPolicyNamespaced).
Collect this as well.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt force-pushed the pr/kkourt/tracingpoliciesnamespaced branch from f2561b0 to 68da562 Compare June 6, 2023 12:42
@kkourt kkourt temporarily deployed to ci June 6, 2023 12:42 — with GitHub Actions Inactive
@kkourt
Copy link
Contributor Author

kkourt commented Jun 6, 2023

You have some build failures; you'll need to update some test files as well.

Thanks! fixed the test, but I'm now getting a failure in the Multicluster test, where the connectivity test seems to fail:

2023-06-06T13:04:23.681118535Z 📋 Test Report
2023-06-06T13:04:23.681135895Z ❌ 1/30 tests failed (1/198 actions), 25 tests skipped, 1 scenarios skipped:
2023-06-06T13:04:23.681142316Z Test [no-policies]:
2023-06-06T13:04:23.681261149Z ❌ no-policies/pod-to-service/curl-0: cilium-test/client-7b78db77d5-rj6xb (10.28.153.183) -> cilium-test/echo-other-node (echo-other-node:8080)
2023-06-06T13:04:23.681421534Z connectivity test failed: 1 tests failed
Error: Process completed with exit code 1.

Seems unrelated to this to PR to me.

@kkourt kkourt requested a review from squeed June 6, 2023 13:56
@squeed
Copy link
Contributor

squeed commented Jun 9, 2023

Seems unrelated to this to PR to me.

Agreed, I'll re-trigger the test.

@kkourt kkourt merged commit c66c893 into main Jun 9, 2023
19 checks passed
@kkourt kkourt deleted the pr/kkourt/tracingpoliciesnamespaced branch June 9, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkourt @squeed