Do not call utils.CheckVersion() in Helm mode #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm mode does not need to know the Cilium version to perform uninstallation. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
CheckVersion() is only relevant to the classic mode. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
asauber
approved these changes
Jun 2, 2023
jrajahalme
approved these changes
Jun 5, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits for helm mode:
uninstall, cilium-cli does not need to know the running cilium version since it simply runshelm uninstall.install,--versionspecifies the Helm chart version. cilium-cli succeeds or fails depending on whether the specified version either exists or it doesn't. there is no need to perform additional version format check.