Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Print Helm chart version in Helm mode #1703

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

michi-covalent
Copy link
Contributor

Print Helm chart version as a part of the "cilium status" output.

@michi-covalent michi-covalent temporarily deployed to ci June 6, 2023 00:58 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor Author

sample output:

./cilium status
    /¯¯\
 /¯¯\__/¯¯\    Cilium:             OK
 \__/¯¯\__/    Operator:           OK
 /¯¯\__/¯¯\    Envoy DaemonSet:    disabled (using embedded mode)
 \__/¯¯\__/    Hubble Relay:       disabled
    \__/       ClusterMesh:        disabled

Deployment             cilium-operator    Desired: 1, Ready: 1/1, Available: 1/1
DaemonSet              cilium             Desired: 1, Ready: 1/1, Available: 1/1
Containers:            cilium             Running: 1
                       cilium-operator    Running: 1
Cluster Pods:          1/1 managed by Cilium
Helm chart version:    1.13.2
Image versions         cilium             quay.io/cilium/cilium:v1.13.2@sha256:85708b11d45647c35b9288e0de0706d24a5ce8a378166cadc700f756cc1a38d6: 1
                       cilium-operator    quay.io/cilium/operator-generic:v1.13.2@sha256:a1982c0a22297aaac3563e428c330e17668305a41865a842dec53d241c5490ab: 1

once this gets merged, i want to replace

func (c *Client) GetRunningCiliumVersion(ctx context.Context, namespace string) (string, error) {
with Helm chart version. GetRunningCiliumVersion is extremely shady. it doesn't work for CI images at all.

Print Helm chart version as a part of the "cilium status" output.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci June 6, 2023 01:03 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review June 6, 2023 03:31
@michi-covalent michi-covalent requested a review from a team as a code owner June 6, 2023 03:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@michi-covalent michi-covalent merged commit c602f76 into main Jun 7, 2023
19 checks passed
@michi-covalent michi-covalent deleted the pr/michi/status-chart branch June 7, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants