Helm mode: Use Helm chart version as running version #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify GetRunningCiliumVersion in Helm mode to return Helm chart version so that the function properly returns the running Cilium version in Helm mode without relying on image tags. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Jun 7, 2023
Testing cilium/cilium-cli#1707 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
|
testing this change in cilium/cilium#25915 ✅ success: https://github.com/cilium/cilium/actions/runs/5204836327 |
tklauser
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify GetRunningCiliumVersion in Helm mode to return Helm chart version so that the function properly returns the running Cilium version in Helm mode without relying on image tags.