Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdump: Fix wrong CiliumLoadBalancerIPPools collector #1731

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

YutaroHayakawa
Copy link
Member

Currently, we incorrectly dump CiliumBGPPeeringPolicy for CiliumLoadBalancerIPPools dump. Fix it.

$ cat ciliumloadbalancerippools-20230331-074532.yaml
apiVersion: cilium.io/v2alpha1
items:
- apiVersion: cilium.io/v2alpha1
  kind: CiliumBGPPeeringPolicy
  metadata:
...

Currently, we incorrectly dump CiliumBGPPeeringPolicy for
CiliumLoadBalancerIPPools dump. Fix it.

```
$ cat ciliumloadbalancerippools-20230331-074532.yaml
apiVersion: cilium.io/v2alpha1
items:
- apiVersion: cilium.io/v2alpha1
  kind: CiliumBGPPeeringPolicy
  metadata:
...
```

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa requested a review from a team as a code owner June 16, 2023 08:53
@YutaroHayakawa YutaroHayakawa temporarily deployed to ci June 16, 2023 08:53 — with GitHub Actions Inactive
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser removed the request for review from derailed June 16, 2023 08:59
@tklauser tklauser merged commit 20d512b into cilium:main Jun 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants