clustermesh enable: add enable-kvstoremesh flag #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the `cilium clustermesh enable` command with a new flag which can be used to enable kvstoremesh (cilium/cilium#26083). The new flag is supported only when using the new Helm mode, and requires cilium >= 1.14 (it has no effect on earlier versions). Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
asauber
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Approving this as a clean implementation that matches the current style.
It brings up two questions for me:
-
Maybe we should reconsider allowing
--helm-setfor subcommands likeclustermesh enable, because we would get features like this for free. -
The chained type-assertion on the Helm values instead of using types is starting to look a bit messy, we should revisit that.
I personally agree. While for certain features it might still better to have a dedicated flag, we also need
That's true. Maybe we could add an helper to set a given value at a certain "path" in the values map. |
michi-covalent
added
the
priority/release-blocker
YutaroHayakawa
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
cilium clustermesh enablecommand with a new flag which can be used to enable kvstoremesh (cilium/cilium#26083). The new flag is supported only when using the new Helm mode, and requires cilium >= 1.14 (it has no effect on earlier versions). Related: cilium/cilium#26348