Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: don't error out if pkill finds no processes #1741

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

tklauser
Copy link
Member

The pkill invocation in the kind workflow is meant to kill background tasks started earlier in the workflow. It seems like some of them exit of their own accord, with tests still passing.

Ignore the pkill error code 1 which indicates that no processes were matched / signalled:

   1      No processes matched or none of them could be signalled.

Ref. cilium/cilium#26075

The pkill invocation in the kind workflow is meant to kill background
tasks started earlier in the workflow. It seems like some of them
exit of their own accord, with tests still passing.

Ignore the pkill error code 1 which indicates that no processes
were matched / signalled:

       1      No processes matched or none of them could be signalled.

Ref. cilium/cilium#26075

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested review from a team as code owners June 21, 2023 12:37
@tklauser tklauser requested a review from nbusseneau June 21, 2023 12:37
@tklauser tklauser temporarily deployed to ci June 21, 2023 12:37 — with GitHub Actions Inactive
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@tklauser tklauser merged commit 0e6d1c8 into main Jun 22, 2023
19 checks passed
@tklauser tklauser deleted the pr/tklauser/gha-ignore-pkill-no-such-process branch June 22, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants