Minor fixes for error messages on failure to disable Hubble #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed the following when uninstalling Cilium:
ℹ️ Failed to disable Hubble. This is expected if Hubble is not enabled: %!s(<nil>)🔮 Auto-detected Kubernetes kind: kind
We have two different messages on the same line. Add missing line breaks
at the end of fmt.Printf() invocations, to avoid joining these unrelated
lines.
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
I observed the following when uninstalling Cilium:
ℹ️ Failed to disable Hubble. This is expected if Hubble is not enabled: %!s(<nil>)🔮 Auto-detected Kubernetes kind: kind
Note the "%!s(<nil>)" error message. This is because the error displayed
is nil, because we do not pass the right error to the fmt.Printf()
invocation to create this message. Let's fix it.
My understanding is that this fix should also prevent the message from
showing up when Hubble has not been enabled, so we can also remove the
related part of the output message.
Fixes: 0eb0600 ("hubble: Remove --base-version flag")
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few minor fixes for some error messages from the CLI, in particular on uninstall when trying to disable Hubble.