Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Normalize --helm-* flags #1744

Merged
merged 1 commit into from
Jun 21, 2023
Merged

install: Normalize --helm-* flags #1744

merged 1 commit into from
Jun 21, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 21, 2023

Normalize the following --helm-* flags so that you can specify these flags with or without the "helm-" prefix:

  • --helm-set: Normalize to --set.
  • --helm-set-file: Normalize to --set-file.
  • --helm-set-string: Normalize to --set-string.
  • --helm-values: Normalize to --values, and add -f shorthand flag.

Fixes: #1701

@michi-covalent michi-covalent temporarily deployed to ci June 21, 2023 20:45 — with GitHub Actions Inactive
@michi-covalent michi-covalent added the priority/release-blocker This issue will prevent the release of the next version of Cilium. label Jun 21, 2023
@michi-covalent michi-covalent temporarily deployed to ci June 21, 2023 20:53 — with GitHub Actions Inactive
Normalize the following --helm-* flags so that you can specify these
flags with or without the "helm-" prefix:

* --helm-set: Normalize to --set.
* --helm-set-file: Normalize to --set-file.
* --helm-set-string: Normalize to --set-string.
* --helm-values: Normalize to --values, and add -f shorthand flag.

Fixes: #1701

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean 😎

@michi-covalent michi-covalent merged commit e74701a into main Jun 21, 2023
19 checks passed
@michi-covalent michi-covalent deleted the pr/michi/flags branch June 21, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue will prevent the release of the next version of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --helm- options compatible with helm install command line in helm mode
2 participants