Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdump: Collect node init Pod logs and DaemonSet #1754

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

ioandr
Copy link
Contributor

@ioandr ioandr commented Jun 23, 2023

Closes #1192

@ioandr ioandr requested a review from a team as a code owner June 23, 2023 09:03
@ioandr ioandr requested a review from derailed June 23, 2023 09:03
@ioandr ioandr temporarily deployed to ci June 23, 2023 09:03 — with GitHub Actions Inactive
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Just a couple picks...

sysdump/sysdump.go Show resolved Hide resolved
sysdump/sysdump.go Outdated Show resolved Hide resolved
@ioandr ioandr temporarily deployed to ci July 6, 2023 19:20 — with GitHub Actions Inactive
@ioandr ioandr requested a review from derailed July 6, 2023 21:38
Closes cilium#1192

Signed-off-by: Ioannis Androulidakis <androulidakis.ioannis@gmail.com>
Signed-off-by: Ioannis Androulidakis <androulidakis.ioannis@gmail.com>
@ioandr ioandr force-pushed the feature-sysdump-node-init branch from 0a96bff to b7a0377 Compare July 7, 2023 08:35
@ioandr ioandr temporarily deployed to ci July 7, 2023 08:35 — with GitHub Actions Inactive
@tklauser tklauser merged commit 4df799b into cilium:main Jul 12, 2023
19 checks passed
@ioandr ioandr deleted the feature-sysdump-node-init branch October 31, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sysdump: Collect logs from cilium-node-init pods
4 participants