Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: extend 'install-cilium-cli' to build from source #1760

Merged

Conversation

giorio94
Copy link
Member

This PR extends the 'install-cilium-cli' composite workflow to additionally support building the cilium CLI from source if the corresponding repository is available locally.

@giorio94 giorio94 requested a review from a team as a code owner June 23, 2023 17:00
@giorio94 giorio94 requested a review from derailed June 23, 2023 17:00
@giorio94 giorio94 temporarily deployed to ci June 23, 2023 17:00 — with GitHub Actions Inactive
@giorio94 giorio94 requested review from a team, christarazi and viktor-kurchenko and removed request for a team June 23, 2023 17:03
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@giorio94 giorio94 added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 26, 2023
This commit extends the 'install-cilium-cli' composite workflow to
additionally support building the cilium CLI from source if the
corresponding repository is available locally.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/action-build-cli-from-source branch from 1242be4 to 6bbac5c Compare June 26, 2023 09:46
@giorio94 giorio94 temporarily deployed to ci June 26, 2023 09:46 — with GitHub Actions Inactive
@giorio94
Copy link
Member Author

Last push split the build and install operations, to avoid issues with caching due to running everything as root

@giorio94 giorio94 removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 26, 2023
@michi-covalent michi-covalent merged commit ef88937 into cilium:main Jun 26, 2023
19 checks passed
@giorio94 giorio94 deleted the mio/action-build-cli-from-source branch June 26, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants