Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Helm mode by default #1762

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Use Helm mode by default #1762

merged 3 commits into from
Jun 26, 2023

Conversation

michi-covalent
Copy link
Contributor

The time has come.

@michi-covalent michi-covalent requested a review from a team as a code owner June 23, 2023 21:58
@michi-covalent michi-covalent temporarily deployed to ci June 23, 2023 21:58 — with GitHub Actions Inactive
@michi-covalent michi-covalent requested review from a team as code owners June 24, 2023 04:37
@michi-covalent michi-covalent temporarily deployed to ci June 24, 2023 04:38 — with GitHub Actions Inactive
@michi-covalent michi-covalent changed the title Use Helm mode by default. Use Helm mode by default Jun 24, 2023
@michi-covalent michi-covalent temporarily deployed to ci June 24, 2023 05:57 — with GitHub Actions Inactive
@michi-covalent michi-covalent added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 24, 2023
@michi-covalent michi-covalent temporarily deployed to ci June 24, 2023 21:59 — with GitHub Actions Inactive
@michi-covalent
uninstall: Remove io.cilium/aws-node-enabled node selector
31cf3d2 
The Helm mode install command still adds io.cilium/aws-node-enabled node
selector unfortunately. Therefore the uninstall command must undo the
change.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
eks-uninstall: Set CILIUM_CLI_MODE environment variable
a0eb151 
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Use Helm mode by default
e925eb2 
The time has come.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci June 25, 2023 03:02 — with GitHub Actions Inactive
@michi-covalent
Copy link
Contributor Author

success

@michi-covalent michi-covalent temporarily deployed to ci June 25, 2023 20:43 — with GitHub Actions Inactive
@michi-covalent michi-covalent removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 25, 2023
brlbil
brlbil approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow 👍

@michi-covalent michi-covalent added the priority/release-blocker This issue will prevent the release of the next version of Cilium. label Jun 26, 2023
@michi-covalent
Copy link
Contributor Author

time to 🚀

@michi-covalent michi-covalent merged commit aac4fff into main Jun 26, 2023
15 of 19 checks passed
@michi-covalent michi-covalent deleted the pr/michi/helm branch June 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@brlbil brlbil brlbil approved these changes

@derailed derailed Awaiting requested review from derailed derailed is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
priority/release-blocker This issue will prevent the release of the next version of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michi-covalent @asauber @brlbil