Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: Expose Features on ConnectivityTest #1764

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

doniacld
Copy link
Contributor

@doniacld doniacld commented Jun 26, 2023

Expose Features on ConnectivityTest structure.

@doniacld doniacld requested a review from a team as a code owner June 26, 2023 12:34
@doniacld doniacld requested a review from derailed June 26, 2023 12:34
@doniacld doniacld temporarily deployed to ci June 26, 2023 12:34 — with GitHub Actions Inactive
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

Features stored whereas a feature is enabled or not and detect if a test should
be run or skipped.  This functionality is useful when cilium-cli packages are
used externally.

Signed-off-by: Donia Chaiehloudj <donia.cld@isovalent.com>
@doniacld doniacld force-pushed the pr/doniacld/expose-features branch from 615f596 to cf07f3b Compare June 26, 2023 12:57
@doniacld doniacld temporarily deployed to ci June 26, 2023 12:58 — with GitHub Actions Inactive
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@michi-covalent michi-covalent merged commit 0ff27b5 into cilium:main Jun 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants