Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: Add op=Exists toleration for test-conn-disrupt #1768

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jun 27, 2023

It was observed on a Kind cluster, that during Cilium upgrade (v1.13.4 -> main) kubelet set the taint node.kubernetes.io/network-unavailable which evicted test-conn-disrupt pods. This resulted in a false negative in the upgrade tests.

Fix the issue by tolerating any taint.

It was observed on a Kind cluster, that during Cilium upgrade (v1.13.4
-> main) kubelet set the taint node.kubernetes.io/network-unavailable
which evicted test-conn-disrupt pods. This resulted in a false negative
in the upgrade tests.

Fix the issue by tolerating any taint.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added the area/CI Continuous Integration testing issue or flake label Jun 27, 2023
@brb brb requested a review from a team as a code owner June 27, 2023 12:40
@brb brb requested a review from asauber June 27, 2023 12:40
@brb brb temporarily deployed to ci June 27, 2023 12:40 — with GitHub Actions Inactive
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for these pods 👍

@michi-covalent
Copy link
Contributor

is the button green? yes.

@michi-covalent michi-covalent merged commit 127d9b8 into main Jun 28, 2023
19 checks passed
@michi-covalent michi-covalent deleted the pr/brb/test-conn-disrupt-tolerations branch June 28, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants