sysdump: do not fail if cilium is not installed #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Cilium is not installed, the namespace of Cilium and Cilium operator cannot be detected. This means that, unless those two parameters are set by the user, the sysdump command will return an error. This means that sysdump canmnot be used in Tetragon installations where Cilium is not installed. This patch changes the code to split the tasks cilium and tetragon tasks, and disable the cilium tasks instead of erring out when the namesapce cannot be autodetected. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
|
Multicluster failure seems unrelated since it does not involve sysdump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Cilium is not installed, the namespace of Cilium and Cilium operator cannot be detected. This means that, unless those two parameters are set by the user, the sysdump command will return an error. This means that sysdump cannot be used in Tetragon installations where Cilium is not installed.
This patch changes the code to split the tasks cilium and tetragon tasks, and disable the cilium tasks instead of erring out when the namesapce cannot be autodetected.