Helm mode: Handle "cluster.name" Helm value #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/clustername
branch
from
c91b68f
to
05b0a3c
Compare
michi-covalent
force-pushed
the
pr/michi/clustername
branch
from
5b7ae2f
to
76bc749
Compare
michi-covalent
force-pushed
the
pr/michi/clustername
branch
from
76bc749
to
7a0a1b5
Compare
michi-covalent
force-pushed
the
pr/michi/clustername
branch
from
7a0a1b5
to
de55eb3
Compare
asauber
approved these changes
Jul 5, 2023
- Refactor preinstall to call HelmOpts.MergeValues() once at the top of the function, and pass the merged values to autodetectAndValidate(). - Set install.Parameters.ClusterName to cluster.name Helm value if it's not empty. - Skip the cluster name validation altogether in Helm mode. I boldly assert that any input validation must be performed inside the Helm chart, and not in cilium-cli. This ensures that the validation logic is consistent between "helm install" and "cilium install". Fixes: #490 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Because why not. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/clustername
branch
from
de55eb3
to
aa3656d
Compare
nebril
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the function, and pass the merged values to autodetectAndValidate().
not empty.
assert that any input validation must be performed inside the Helm
chart, and not in cilium-cli. This ensures that the validation logic
is consistent between "helm install" and "cilium install".
Fixes: #490
Signed-off-by: Michi Mutsuzaki michi@isovalent.com