connectivity: don't wait for service backends if the IP family is disabled #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dccab2 ("connectivity: wait for service propagation in agents") introduced an additional check to wait until all test services have been synchronized by cilium agents before starting the actual tests. Yet, this check will never succeed if the cluster is configured in dual stack mode, but only one IP family is enabled by Cilium. Indeed, the backends for the disabled IP family will never be populated. Hence, let's skip this check if the ClusterIP belongs to a disabled IP family. Fixes: 0dccab2 ("connectivity: wait for service propagation in agents") Reported-by: Donia Chaiehloudj <donia.cld@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
changed the title
doniacld
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0dccab2 ("connectivity: wait for service propagation in agents") introduced an additional check to wait until all test services have been synchronized by cilium agents before starting the actual tests. Yet, this check will never succeed if the cluster is configured in dual stack mode, but only one IP family is enabled by Cilium. Indeed, the backends for the disabled IP family will never be populated. Hence, let's skip this check if the ClusterIP belongs to a disabled IP family.
Fixes: 0dccab2 ("connectivity: wait for service propagation in agents")
Reported-by: Donia Chaiehloudj