Create a separate RESTClientGetter for Helm client #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing the same RESTClientGetter between Helm client and direct Kubernetes API calls causes "concurrent map read and map write" fatal error as reported in #1794. Introduce a dedicated RESTClientGetter for Helm client so that you don't have to worry about synchronizing access to the same RESTClientGetter. No sharing, no concurrent map read and map write. Problem solved. Fixes: #1794 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added
the
priority/release-blocker
michi-covalent
requested review from
joamaki,
asauber,
lambdanis and
YutaroHayakawa
asauber
approved these changes
Jul 6, 2023
no i'm relying on our amazing test coverage 😇 |
bimmlerd
approved these changes
Jul 7, 2023
tklauser
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing the same RESTClientGetter between Helm client and direct Kubernetes API calls causes "concurrent map read and map write" fatal error as reported in #1794. Introduce a dedicated RESTClientGetter for Helm client so that you don't have to worry about synchronizing access to the same RESTClientGetter. No sharing, no concurrent map read and map write. Problem solved.
Fixes: #1794